-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Upgrading Cypress to version 12. #6990
Conversation
Nice work on this Trevor! @tkajtoch do you have any preference to merging this in before or after the React 18 feature branch? I'm not sure if this will cause any issues for the existing package.json changes / Cypress setup work in that feature branch. |
buildkite test this |
@cee-chen I'll test this against |
Thanks @cee-chen && @tkajtoch! I'm tweaking the Buildkite runtime commands a touch to make sure it runs at the right times for pull requests against any branch, and for forked repo requests. I'll wait to get a thumbs up here and merge that work before merging this one. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6990/ |
1 similar comment
Preview documentation changes for this PR: https://eui.elastic.co/pr_6990/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6990_buildkite/ |
* Bumping Cypress to version 12.17.0. * Changing invoke to then to resolve promise and not throw an error.
f966308
to
ee71863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran yarn test-cypress
3 times locally, passed each time.
FYI yarn test-cypress-a11y
is now failing on main due to the React 18 changes, but I think that can/should be resolved separately from this PR. Follow up issue: #7024
Preview documentation changes for this PR: https://eui.elastic.co/pr_6990/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_6990_buildkite/ |
Summary
Bumping Cypress to version
12.17.0
(current release)v12
#6917Changed one test's
invoke()
method to resolve a promise usingthen()
per the Cypress changelog:QA
Ran Cypress tests locally:
yarn test-cypress
yarn test-cypress-a11y